Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump relayer memory usage to 20GB, start using new SVM submission in relayer #5063

Merged
merged 6 commits into from
Dec 26, 2024
Merged

feat: bump relayer memory usage to 20GB, start using new SVM submission in relayer #5063

merged 6 commits into from
Dec 26, 2024

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Dec 20, 2024 •
edited
Loading

Description

  • deploys feat: SVM priority fee oracles and transaction submitters, more consistent tx submission #4959
  • Sets a small priority fee for Eclipse following some recent spikes there, https://discord.com/channels/935678348330434570/1320851852157255701 for context
  • Makes the relayer request 20GB of memory, forcing relayers to have their own node in our bigger node pool (capacity 29 GB)
  • Driveby to use G (Gigabytes) instead of Gi (Gibibytes) to match what GCP uses in their UI, also a bit more intuitive
  • Added a --concurrency <num> flag that can be used when deploying agents. Especially useful when releasing to all validators, which we have tons of now.
  • Concurrently refetching remote repositories on helm poses issues, so I made this not happen by default anymore. It's not configurable at the CLI level to enable it, but we have the ability to easily add it later. Because our agent deploy doesn't actually require any remote helm repos, it's not necessary
  • already rolled out

Drive-by changes

Related issues

Backward compatibility

Testing

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2416be1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/utils Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/widgets Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/github-proxy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

cmcewen
cmcewen requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@cmcewen cmcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests not passing

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (e9911bb) to head (e550d42).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5063   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@tkporter tkporter changed the title feat: bump relayer memory usage to 20GB, add concurrency to agent deploys feat: bump relayer memory usage to 20GB, start using new SVM submission in relayer Dec 23, 2024
@tkporter tkporter added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit 8834a8c Dec 26, 2024
41 checks passed
@tkporter tkporter deleted the trevor/relayer-20-gb branch December 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-savu daniel-savu daniel-savu approved these changes

@paulbalaji paulbalaji paulbalaji approved these changes

@cmcewen cmcewen cmcewen approved these changes

@Mo-Hussain Mo-Hussain Awaiting requested review from Mo-Hussain Mo-Hussain is a code owner

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

@jmrossy jmrossy Awaiting requested review from jmrossy jmrossy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkporter @cmcewen @paulbalaji @daniel-savu